Skip to content

[cherry-pick]Removing redundant flags across binaries (#11522)#11589

Merged
deepthi merged 2 commits intovitessio:mainfrom
planetscale:cherrypick-11522
Nov 1, 2022
Merged

[cherry-pick]Removing redundant flags across binaries (#11522)#11589
deepthi merged 2 commits intovitessio:mainfrom
planetscale:cherrypick-11522

Conversation

@rsajwani
Copy link
Copy Markdown
Contributor

@rsajwani rsajwani commented Oct 27, 2022 •
edited
Loading

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

Description

cherry-pick (#11522)

Related Issue(s)

rohit-nayak-ps/vreplication-docs#2

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@rsajwani
Removing redundant flags across binaries (vitessio#11522)
5e4c685 
* removing redundant flags across binaries

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* adding app pool flag back for some binaries

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* running generate_ci on prscomplex.yml

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* code review

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing markdeprecated error

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* code feedback

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* doing some minor changes

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing typo

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 27, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani rsajwani self-assigned this Oct 27, 2022
@rsajwani rsajwani added Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Oct 27, 2022
@rsajwani
Merge remote-tracking branch 'upstream/main' into cherrypick-11522
ac6c1d1 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani marked this pull request as ready for review November 1, 2022 18:43
@rsajwani
Copy link
Copy Markdown
Contributor Author

rsajwani commented Nov 1, 2022

vttablet_prscomplex, is failing but that is unrelated to this PR ...

@deepthi deepthi merged commit adeccd2 into vitessio:main Nov 1, 2022
@deepthi deepthi deleted the cherrypick-11522 branch November 1, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

@ajm188 ajm188 Awaiting requested review from ajm188

@notfelineit notfelineit Awaiting requested review from notfelineit

@rafael rafael Awaiting requested review from rafael

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rsajwani rsajwani

Labels

Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rsajwani @deepthi